Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: java 11 support #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Draft: java 11 support #63

wants to merge 1 commit into from

Conversation

Turmio
Copy link
Contributor

@Turmio Turmio commented Apr 4, 2023

Java 11 support. Currently tested on Windows machine so may need some extra work on other machines. CI is not fixed yet.

Implements #23

Copy link
Contributor Author

@Turmio Turmio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR also includes some of https://github.com/eficode/JavaFXLibrary/tree/java-11-support branch solutions and has solutions to unresolved issues in that branch.

@@ -50,7 +53,7 @@ public void getMouseButtons_MultipleValues() {
public void getMouseButtons_InvalidValue() {
thrown.expect(JavaFXLibraryNonFatalException.class);
// thrown.expect(IllegalArgumentException.class);
thrown.expectMessage("\"HUGE_RED_ONE\" is not a valid MouseButton. Accepted values are: [NONE, PRIMARY, MIDDLE, SECONDARY]");
thrown.expectMessage("\"HUGE_RED_ONE\" is not a valid MouseButton. Accepted values are: " + Arrays.asList(MouseButton.values()));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a mouse with back and forward buttons. Test failed since message had BACK and FORWARD values.

@@ -391,7 +424,7 @@
<dependency>
<groupId>org.testfx</groupId>
<artifactId>openjfx-monocle</artifactId>
<version>8u76-b04</version>
<version>jdk-12.0.1+2</version>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jdk-11+26 version did not work. Had some missing methods. Upgrading resolved issues.

@@ -128,6 +128,8 @@ public JavaFXLibrary(boolean headless) {
if (headless) {
System.setProperty("testfx.robot", "glass");
System.setProperty("testfx.headless", "true");
System.setProperty("glass.platform", "Monocle");
System.setProperty("monocle.platform", "Headless");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relates to previous comment. Maybe these are not necessary?

RobotLog.info("Index number: " + i);
columnCells.add(mapObject(vf.getCell(i).getChildrenUnmodifiable().get(column)));
}
Optional<VirtualFlow> vf = table.getChildrenUnmodifiable().stream().filter(node -> node instanceof VirtualFlow).map(VirtualFlow.class::cast).findFirst();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed public API in JavaFX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant